[Accepted] [TW] Mix Weapon Type Transmog
Re: [TW] Mix Weapon Type Transmog
well I vote yes for it. But I'm not sure about one thing. want to sort it out
So you will able to transmog your weapon into something other, that you OWN or OWN and have already equipped?
So you will able to transmog your weapon into something other, that you OWN or OWN and have already equipped?
Long Live Rock'n'Roll
\m/ UNDYABLE \m/
\m/ UNDYABLE \m/
Re: [TW] Mix Weapon Type Transmog
No. You do not have to have equipped it.
But you will have to BE ABLE TO USE it.
But you will have to BE ABLE TO USE it.
PC
MB: Asus M5A97 R2.0 (AM3+); CPU: AMD FX 8300 (@4,2GHz); GPU: Gigabyte R9 380 4GB GDDR5 (@1,15GHz); RAM: Kingston HyperX Fury 1866MHz (2x4GB Kit); PSU: Coolermaster V550 (80+ Gold); CPU Cooler: LC-CC-120; Case: Antec GX505; Fans: Antec TrueQuiet 120mm x5; Monitor: AOC G2460PF (24'', 1ms, 144Hz, Freesync); Keyboard: Corsair Strafe RGB (Cherry MX Red); Mouse: Logitech G302; Surface: Roccat Taito Mid 5mm
MB: Asus M5A97 R2.0 (AM3+); CPU: AMD FX 8300 (@4,2GHz); GPU: Gigabyte R9 380 4GB GDDR5 (@1,15GHz); RAM: Kingston HyperX Fury 1866MHz (2x4GB Kit); PSU: Coolermaster V550 (80+ Gold); CPU Cooler: LC-CC-120; Case: Antec GX505; Fans: Antec TrueQuiet 120mm x5; Monitor: AOC G2460PF (24'', 1ms, 144Hz, Freesync); Keyboard: Corsair Strafe RGB (Cherry MX Red); Mouse: Logitech G302; Surface: Roccat Taito Mid 5mm
Re: [TW] Mix Weapon Type Transmog
So basically if I have a BoE item I can trade it endlessly to my friends and let them get the mog? or u actually have to have it in your bag for mog to work?
Long Live Rock'n'Roll
\m/ UNDYABLE \m/
\m/ UNDYABLE \m/
Re: [TW] Mix Weapon Type Transmog
No.slocraft wrote:So basically if I have a BoE item I can trade it endlessly to my friends and let them get the mog? or u actually have to have it in your bag for mog to work?
Think his wording alittle odd.
You have to be able to equip the weapon and have it binded to yourself (equip BoE items)
Matsy pls
Mats - Frost PVE Troll Death Knight - Retired
Matsy - Moonkin/Restoration Druid (Laz0r Chicken)
Mat - Beastmaster Orc Hunter
Matz -Retribution Paladin
Matu - Troll Shadow Priest
Bolts - Elemental Troll Shaman
Kungfu - Orc Fury Warrior
Trollage - Troll Arcane Mage
Mato - Orc Affliction Warlock
Findme - Troll Assassination Rogue
I Pity the Fool who's illogical
Friends are just people you hate the least
I reject your reality and substitute my own
Mats - Frost PVE Troll Death Knight - Retired
Matsy - Moonkin/Restoration Druid (Laz0r Chicken)
Mat - Beastmaster Orc Hunter
Matz -Retribution Paladin
Matu - Troll Shadow Priest
Bolts - Elemental Troll Shaman
Kungfu - Orc Fury Warrior
Trollage - Troll Arcane Mage
Mato - Orc Affliction Warlock
Findme - Troll Assassination Rogue
I Pity the Fool who's illogical
Friends are just people you hate the least
I reject your reality and substitute my own
Re: [TW] Mix Weapon Type Transmog
item has to be soulbound, and something you can wear, simple logic
Re: [Pending] Mix Weapon Type Transmog
There was a thank you note to Rochet2 on our Transmog FAQ page, so I took a look Rochet2's source code and they had the "curious" allow mixed weapon future. I am guessing that this is the source code used for our transmog.
The problem with the "allowMixedWeapon" future is that you can mix some weapons that shouldn't be mixable. To fix the problem, we have to some extra logic towards the end of this function.
First we need some weapons pools. They already had the IsRangedWeapon method.
We need one for OneHandedWeapons
and TwoHandedWeapons.
To allow main hand dagger (otherwise known as caster dagger) to be transmogged into a OneHandedWeapon, I added a method to check if the weapon is a main hand dagger.
Finally, we need to make sure the rest of the weapons that don't belong in any of these weapon pools can't be the source for other weapons.
Now we only have to update this part with the new functions to make it work.
Could we give this a try on the PTR?
The problem with the "allowMixedWeapon" future is that you can mix some weapons that shouldn't be mixable. To fix the problem, we have to some extra logic towards the end of this function.
First we need some weapons pools. They already had the IsRangedWeapon method.
We need one for OneHandedWeapons
Code: Select all
bool Transmogrification::IsOneHandedWeapon(uint32 Class, uint32 SubClass) const
{
TC_LOG_DEBUG("custom.transmog", "Transmogrification::IsOneHandedWeapon");
return Class == ITEM_CLASS_WEAPON && (
SubClass == ITEM_SUBCLASS_WEAPON_AXE ||
SubClass == ITEM_SUBCLASS_WEAPON_MACE ||
SubClass == ITEM_SUBCLASS_WEAPON_SWORD);
}
Code: Select all
bool Transmogrification::IsTwoHandedWeapon(uint32 Class, uint32 SubClass) const
{
TC_LOG_DEBUG("custom.transmog", "Transmogrification::IsTwoHandedWeapon");
return Class == ITEM_CLASS_WEAPON && (
SubClass == ITEM_SUBCLASS_WEAPON_AXE2 ||
SubClass == ITEM_SUBCLASS_WEAPON_MACE2 ||
SubClass == ITEM_SUBCLASS_WEAPON_SWORD2 ||
SubClass == ITEM_SUBCLASS_WEAPON_STAFF ||
SubClass == ITEM_SUBCLASS_WEAPON_POLEARM);
}
Code: Select all
bool Transmogrification::IsMainHandDagger(ItemTemplate const* item) const
{
TC_LOG_DEBUG("custom.transmog", "Transmogrification::IsMainHandDagger");
return item->Class == ITEM_CLASS_WEAPON && item->InventoryType == INVTYPE_WEAPONMAINHAND && item->SubClass == ITEM_SUBCLASS_WEAPON_DAGGER;
}
Code: Select all
bool Transmogrification::BadWeaponSource(uint32 SubClass) const
{
TC_LOG_DEBUG("custom.transmog", "Transmogrification::BadWeaponSource");
return Class == ITEM_CLASS_WEAPON && (
SubClass == ITEM_SUBCLASS_WEAPON_FIST_WEAPON ||
SubClass == ITEM_SUBCLASS_WEAPON_DAGGER ||
SubClass == ITEM_SUBCLASS_WEAPON_THROWN ||
SubClass == ITEM_SUBCLASS_WEAPON_SPEAR ||
SubClass == ITEM_SUBCLASS_WEAPON_WAND ||
SubClass == ITEM_SUBCLASS_WEAPON_FISHING_POLE);
}
Code: Select all
if (source->InventoryType != target->InventoryType || (AllowMixedArmorTypes && source->Class == ITEM_CLASS_WEAPON))
{
if (source->Class == ITEM_CLASS_WEAPON &&
(IsRangedWeapon(target->Class, target->SubClass) != IsRangedWeapon(source->Class, source->SubClass) ||
IsTwoHandedWeapon(target->Class, target->SubClass) != IsTwoHandedWeapon(source->Class, source->SubClass) ||
(IsOneHandedWeapon(target->Class, target->SubClass) != IsOneHandedWeapon(source->Class, source->SubClass) && !IsMainHandDagger(target)) ||
source->InventoryType == INVTYPE_WEAPONMAINHAND ||
source->InventoryType == INVTYPE_WEAPONOFFHAND ||
BadWeaponSource(source->SubClass)))
return false;
if (source->Class == ITEM_CLASS_ARMOR &&
!((source->InventoryType == INVTYPE_CHEST && target->InventoryType == INVTYPE_ROBE) ||
(source->InventoryType == INVTYPE_ROBE && target->InventoryType == INVTYPE_CHEST)))
return false;
}
Re: [Pending] Mix Weapon Type Transmog
Give it a try plz!!
Re: [TW] Mix Weapon Type Transmog
Shouldn't priorities be set by what the community wants?Nyeriah wrote:Pending, very, very, very low priority atm
And judging by the ammount of activity in this thread compared to other threads and the ammount of transmog hunters out there in the server, I would say that transmog is currently very high on community's list of wanted upgrades/updates/fixes.
PC
MB: Asus M5A97 R2.0 (AM3+); CPU: AMD FX 8300 (@4,2GHz); GPU: Gigabyte R9 380 4GB GDDR5 (@1,15GHz); RAM: Kingston HyperX Fury 1866MHz (2x4GB Kit); PSU: Coolermaster V550 (80+ Gold); CPU Cooler: LC-CC-120; Case: Antec GX505; Fans: Antec TrueQuiet 120mm x5; Monitor: AOC G2460PF (24'', 1ms, 144Hz, Freesync); Keyboard: Corsair Strafe RGB (Cherry MX Red); Mouse: Logitech G302; Surface: Roccat Taito Mid 5mm
MB: Asus M5A97 R2.0 (AM3+); CPU: AMD FX 8300 (@4,2GHz); GPU: Gigabyte R9 380 4GB GDDR5 (@1,15GHz); RAM: Kingston HyperX Fury 1866MHz (2x4GB Kit); PSU: Coolermaster V550 (80+ Gold); CPU Cooler: LC-CC-120; Case: Antec GX505; Fans: Antec TrueQuiet 120mm x5; Monitor: AOC G2460PF (24'', 1ms, 144Hz, Freesync); Keyboard: Corsair Strafe RGB (Cherry MX Red); Mouse: Logitech G302; Surface: Roccat Taito Mid 5mm
Re: [TW] Mix Weapon Type Transmog
I am already working on this and it's soon to be released, should I manage to fix the few issues left.Gadoschi wrote:Shouldn't priorities be set by what the community wants?Nyeriah wrote:Pending, very, very, very low priority atm
And judging by the ammount of activity in this thread compared to other threads and the ammount of transmog hunters out there in the server, I would say that transmog is currently very high on community's list of wanted upgrades/updates/fixes.
Re: [Pending] Mix Weapon Type Transmog
That's great news.
PC
MB: Asus M5A97 R2.0 (AM3+); CPU: AMD FX 8300 (@4,2GHz); GPU: Gigabyte R9 380 4GB GDDR5 (@1,15GHz); RAM: Kingston HyperX Fury 1866MHz (2x4GB Kit); PSU: Coolermaster V550 (80+ Gold); CPU Cooler: LC-CC-120; Case: Antec GX505; Fans: Antec TrueQuiet 120mm x5; Monitor: AOC G2460PF (24'', 1ms, 144Hz, Freesync); Keyboard: Corsair Strafe RGB (Cherry MX Red); Mouse: Logitech G302; Surface: Roccat Taito Mid 5mm
MB: Asus M5A97 R2.0 (AM3+); CPU: AMD FX 8300 (@4,2GHz); GPU: Gigabyte R9 380 4GB GDDR5 (@1,15GHz); RAM: Kingston HyperX Fury 1866MHz (2x4GB Kit); PSU: Coolermaster V550 (80+ Gold); CPU Cooler: LC-CC-120; Case: Antec GX505; Fans: Antec TrueQuiet 120mm x5; Monitor: AOC G2460PF (24'', 1ms, 144Hz, Freesync); Keyboard: Corsair Strafe RGB (Cherry MX Red); Mouse: Logitech G302; Surface: Roccat Taito Mid 5mm
Re: [Pending] Mix Weapon Type Transmog
It's enabled on the PTR now, so if you want to help me debug, please do.
Re: [Pending] Mix Weapon Type Transmog
What are the bugs concerning?
PC
MB: Asus M5A97 R2.0 (AM3+); CPU: AMD FX 8300 (@4,2GHz); GPU: Gigabyte R9 380 4GB GDDR5 (@1,15GHz); RAM: Kingston HyperX Fury 1866MHz (2x4GB Kit); PSU: Coolermaster V550 (80+ Gold); CPU Cooler: LC-CC-120; Case: Antec GX505; Fans: Antec TrueQuiet 120mm x5; Monitor: AOC G2460PF (24'', 1ms, 144Hz, Freesync); Keyboard: Corsair Strafe RGB (Cherry MX Red); Mouse: Logitech G302; Surface: Roccat Taito Mid 5mm
MB: Asus M5A97 R2.0 (AM3+); CPU: AMD FX 8300 (@4,2GHz); GPU: Gigabyte R9 380 4GB GDDR5 (@1,15GHz); RAM: Kingston HyperX Fury 1866MHz (2x4GB Kit); PSU: Coolermaster V550 (80+ Gold); CPU Cooler: LC-CC-120; Case: Antec GX505; Fans: Antec TrueQuiet 120mm x5; Monitor: AOC G2460PF (24'', 1ms, 144Hz, Freesync); Keyboard: Corsair Strafe RGB (Cherry MX Red); Mouse: Logitech G302; Surface: Roccat Taito Mid 5mm
Re: [Pending] Mix Weapon Type Transmog
If you can switch within a weapon pool and can't go beyond the weapon pool. As well as check items not in weapon pools.Gadoschi wrote:What are the bugs concerning?
It seemed fine when I tested it, besides legendaries, but I think that's just some configuration setting difference between PTR and TW.
Re: [Pending] Mix Weapon Type Transmog
This is now enabled for the TrueWoW realm.
[hide]Pool 1: Ranged Weapons (Already existing)
If you find any bugs (i.e. illegal transmogs), please notify through PM so I can look into it.
[hide]Pool 1: Ranged Weapons (Already existing)
- Gun
- Bow
- Crossbow
- Two-Handed Axe
- Two-Handed Mace
- Two-Handed Sword
- Polearm
- Staff
- Axe
- Mace
- Sword
- Main-Hand Dagger to the others, but not others to Main-Hand Dagger
If you find any bugs (i.e. illegal transmogs), please notify through PM so I can look into it.
Who is online
Users browsing this forum: No registered users and 2 guests